Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency react-markdown to v9 #14579

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 27, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
react-markdown ^8.0.0 -> ^9.0.0 age adoption passing confidence

Release Notes

remarkjs/react-markdown (react-markdown)

v9.0.0

Compare Source

  • b67d714
    Change to require Node.js 16
    migrate: update too
  • ec2b134
    Change to require React 18
    migrate: update too
  • bf5824f
    Change to use exports
    migrate: don’t use private APIs
  • c383a45
    Update @types/hast, utilities, plugins, etc
    migrate: update too
  • eca5e6b
    08ead9e
    Replace transformImageUri, transformLinkUri w/ urlTransform
    migrate: see “Add urlTransform” below
  • de29396
    Remove linkTarget option
    migrate: see “Remove linkTarget” below
  • 4346276
    Remove support for passing custom props to components
    migrate: see “Remove includeElementIndex”, “Remove rawSourcePos”,
    “Remove sourcePos”, “Remove extra props passed to certain components”
    below
  • c0dfbd6
    Remove UMD bundle from package
    migrate: use esm.sh or a CDN or so
  • e12b5e9
    Remove prop-types
    migrate: use TypeScript
  • 4eb7aa0
    Change to throw errors for removed props
    migrate: don’t pass options that don’t do things
  • 8aabf74
    Change to improve error messages
    migrate: expect better messages
Add urlTransform

The transformImageUri and transformLinkUri were removed.
Having two functions is a bit much, particularly because there are more URLs
you might want to change (or which might be unsafe so we make them safe).
And their name and APIs were a bit weird.
You can use the new urlTransform prop instead to change all your URLs.

Remove linkTarget

The linkTarget option was removed; you should likely not set targets.
If you want to, use
rehype-external-links.

Remove includeElementIndex

The includeElementIndex option was removed, so index is never passed to
components.
Write a plugin to pass index:

Show example of plugin
import {visit} from 'unist-util-visit'

function rehypePluginAddingIndex() {
  /**
   * @​param {import('hast').Root} tree
   * @​returns {undefined}
   */
  return function (tree) {
    visit(tree, function (node, index) {
      if (node.type === 'element' && typeof index === 'number') {
        node.properties === index
      }
    })
  }
}
Remove rawSourcePos

The rawSourcePos option was removed, so sourcePos is never passed to
components.
All components are passed node, so you can get node.position from them.

Remove sourcePos

The sourcePos option was removed, so data-sourcepos is never passed to
elements.
Write a plugin to pass index:

Show example of plugin
import {stringifyPosition} from 'unist-util-stringify-position'
import {visit} from 'unist-util-visit'

function rehypePluginAddingIndex() {
  /**
   * @​param {import('hast').Root} tree
   * @​returns {undefined}
   */
  return function (tree) {
    visit(tree, function (node) {
      if (node.type === 'element') {
        node.properties.dataSourcepos = stringifyPosition(node.position)
      }
    })
  }
}
Remove extra props passed to certain components

When overwriting components, these props are no longer passed:

  • inline on code:
    — create a plugin or use pre for the block
  • level on h1, h2, h3, h4, h5, h6
    — check node.tagName instead
  • checked on li
    — check task-list-item class or check props.children
  • index on li
    — create a plugin
  • ordered on li
    — create a plugin or check the parent
  • depth on ol, ul
    — create a plugin
  • ordered on ol, ul
    — check node.tagName instead
  • isHeader on td, th
    — check node.tagName instead
  • isHeader on tr
    — create a plugin or check children

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@netlify
Copy link

netlify bot commented Sep 27, 2023

Deploy Preview for jestjs ready!

Name Link
🔨 Latest commit 04685cf
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/65145c695bd38300087dd0ce
😎 Deploy Preview https://deploy-preview-14579--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SimenB
Copy link
Member

SimenB commented Sep 28, 2023

dropped node 16 seemingly

@SimenB SimenB closed this Sep 28, 2023
@renovate
Copy link
Contributor Author

renovate bot commented Sep 28, 2023

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 9.x releases. But if you manually upgrade to 9.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/react-markdown-9.x branch September 28, 2023 09:30
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant