Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecate jest-repl #14459

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

chore: deprecate jest-repl #14459

wants to merge 11 commits into from

Conversation

eryue0220
Copy link
Contributor

@eryue0220 eryue0220 commented Aug 30, 2023 •
edited
Loading

Summary

Fix #14441
Deprecate package jest-repl

Test plan

@netlify
Copy link

netlify bot commented Aug 30, 2023 •
edited
Loading

✅ Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5036e2c
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/65def6286936ee0008d4815e
😎 Deploy Preview https://deploy-preview-14459--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mrazauskas
mrazauskas reviewed Aug 30, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@mrazauskas mrazauskas added this to the Jest 30 milestone Aug 30, 2023
SimenB
SimenB approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

FWIW, I'll land this after releasing v30 as I want to deprecate that version on npm

.eslintrc.cjs Outdated Show resolved Hide resolved
@SimenB
Copy link
Member

SimenB commented Sep 27, 2023

Should also delete

jest/scripts/buildUtils.mjs

Lines 218 to 219 in 2461639

: pkg.name === 'jest-repl'
? {repl: path.resolve(packageDir, './src/cli/repl.ts')}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrazauskas mrazauskas mrazauskas left review comments

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Jest 30
Development

Successfully merging this pull request may close these issues.

[Feature]: Deprecate jest-repl
3 participants
@eryue0220 @SimenB @mrazauskas