-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Archive docs versions 29.3 and below #14425
Conversation
✅ Deploy Preview for jestjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my inline comments to help review this PR
@@ -92,7 +92,7 @@ | |||
"clean-all": "yarn clean-e2e && yarn build-clean && rimraf --glob './packages/*/node_modules' && rimraf './node_modules'", | |||
"clean-e2e": "node ./scripts/cleanE2e.mjs", | |||
"crowdin:upload": "echo 'Uploading sources to Crowdin' && crowdin upload sources --config ./crowdin.yaml", | |||
"crowdin:download": "echo 'Downloading translations from Crowdin' && crowdin download --config ./crowdin.yaml", | |||
"crowdin:download": "echo 'Downloading translations from Crowdin' && crowdin download --config ./crowdin.yaml --language ja --language es-ES --language fr --language pt-BR --language ro --language ru --language uk --language zh-CN", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can help speed up your Netlify prod deployment a bit.
I doubt you plan to introduce any new language so this should be fine 🤷♂️
"28.x": "https://jest-archive-august-2023.netlify.app/docs/28.x/getting-started/", | ||
"27.x": "https://jest-archive-august-2023.netlify.app/docs/27.x/getting-started/", | ||
"26.x": "https://jest-archive-august-2023.netlify.app/docs/26.x/getting-started/", | ||
"25.x": "https://jest-archive-august-2023.netlify.app/docs/25.x/getting-started/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These urls could be "cleaned" once we know where to store the archives.
Related to the process here: facebook/react-native-website#3819
Note: if Meta adopts a given archiving process for React-Native, OpenJS remains free to adopt another process if needed.
For now many things are still under Meta's accounts:
- Jest Netlify sites: prod, v1 archive, august-2023 archive
- Jest Crowdin account
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should resolve this, thanks for bringing it up!
@@ -183,7 +183,7 @@ const config = { | |||
dropdownItemsAfter: [ | |||
...Object.entries(ArchivedVersions).map( | |||
([versionName, versionUrl]) => ({ | |||
to: versionUrl, | |||
href: versionUrl, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Archive older versions of docs that are not receiving any meaningful updates
Related to a similar work done on the React-Native website (facebook/react-native-website#3818)
This will help reduce the docs update work required for the Docusaurus v3 upgrade
Note: there's a RN RFC to define a proper docs archiving process here: facebook/react-native-website#3819
cc @SimenB
Test plan
Deploy preview