Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive docs versions 29.3 and below #14425

Merged
merged 3 commits into from
Aug 18, 2023

Conversation

slorber
Copy link
Contributor

@slorber slorber commented Aug 17, 2023

Summary

Archive older versions of docs that are not receiving any meaningful updates

Related to a similar work done on the React-Native website (facebook/react-native-website#3818)

This will help reduce the docs update work required for the Docusaurus v3 upgrade

Note: there's a RN RFC to define a proper docs archiving process here: facebook/react-native-website#3819

cc @SimenB

Test plan

Deploy preview

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 17, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@netlify
Copy link

netlify bot commented Aug 17, 2023

Deploy Preview for jestjs ready!

Name Link
🔨 Latest commit ab1178f
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/64de613754d40b00081c5998
😎 Deploy Preview https://deploy-preview-14425--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor Author

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my inline comments to help review this PR

@@ -92,7 +92,7 @@
"clean-all": "yarn clean-e2e && yarn build-clean && rimraf --glob './packages/*/node_modules' && rimraf './node_modules'",
"clean-e2e": "node ./scripts/cleanE2e.mjs",
"crowdin:upload": "echo 'Uploading sources to Crowdin' && crowdin upload sources --config ./crowdin.yaml",
"crowdin:download": "echo 'Downloading translations from Crowdin' && crowdin download --config ./crowdin.yaml",
"crowdin:download": "echo 'Downloading translations from Crowdin' && crowdin download --config ./crowdin.yaml --language ja --language es-ES --language fr --language pt-BR --language ro --language ru --language uk --language zh-CN",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can help speed up your Netlify prod deployment a bit.
I doubt you plan to introduce any new language so this should be fine 🤷‍♂️

Comment on lines +2 to +5
"28.x": "https://jest-archive-august-2023.netlify.app/docs/28.x/getting-started/",
"27.x": "https://jest-archive-august-2023.netlify.app/docs/27.x/getting-started/",
"26.x": "https://jest-archive-august-2023.netlify.app/docs/26.x/getting-started/",
"25.x": "https://jest-archive-august-2023.netlify.app/docs/25.x/getting-started/",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These urls could be "cleaned" once we know where to store the archives.
Related to the process here: facebook/react-native-website#3819

Note: if Meta adopts a given archiving process for React-Native, OpenJS remains free to adopt another process if needed.
For now many things are still under Meta's accounts:

  • Jest Netlify sites: prod, v1 archive, august-2023 archive
  • Jest Crowdin account

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should resolve this, thanks for bringing it up!

@@ -183,7 +183,7 @@ const config = {
dropdownItemsAfter: [
...Object.entries(ArchivedVersions).map(
([versionName, versionUrl]) => ({
to: versionUrl,
href: versionUrl,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes external links more visible on the dropdown:

CleanShot 2023-08-17 at 19 42 15@2x

@slorber slorber changed the title Archive docs versions 28.x and below Archive docs versions 29.3 and below Aug 17, 2023
@SimenB SimenB merged commit eb61702 into jestjs:main Aug 18, 2023
87 of 89 checks passed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants