Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline Installation Bugfixes #73

Merged
merged 8 commits into from
Dec 2, 2022
Merged

Offline Installation Bugfixes #73

merged 8 commits into from
Dec 2, 2022

Conversation

jessety
Copy link
Owner

@jessety jessety commented Dec 2, 2022

Description

  • Fix an issue that prevented offline installation on Windows due to a discrepancy in the version of pm2 we were caching and the one a dependency requested (ENOTCACHED)
  • Fix an issue that prevented offline installation on Windows due to the behavior of npm link (ENOTCACHED)
  • Update formatting rules & format the codebase
  • Update pull request and issue templates slightly

Testing

Windows 10, Server 2016

Fixes or Features

Fixes:
#62
#52
#51

1. When installing the logrotate package it'd try to install a different version pm2 as a dependency than the one we'd cached, and fail
2. When linking `node-windows`, it'd try to install all other dependencies too. Remove them before attempting it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant