Update messaging in case splitting is skipped and check for UsageErrors more aggressively #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 18, 2021 21:41
We need to able to store state so that we can report on the result of the splitting of the test suite in the corresponding hook. This commit makes the plugin a class without changing existing behaviour.
The pytest_report_collectionfinish is the hook that gets called after item collection. That seems to be the right moment to report on the splitting result. This commit ensures pytest-split always reports how the test were split and uses the same message as before.
mbkroese
changed the title
|
@jerry-git I noticed one issue when the user has the plugin installed without passing any pytest-split arguments. Will fix that shortly. |
@jerry-git I updated the MR to fix this. Could you let me know what you think? |
jerry-git
reviewed
May 31, 2021
jerry-git
reviewed
May 31, 2021
jerry-git
reviewed
May 31, 2021
added 5 commits
June 5, 2021 15:30
This commit adds two pieces of functionality: 1. verify that neither OR both splits and group are passed 2. verify that the group argument is within valid range
mbkroese
changed the title
|
@jerry-git please have another look! |
|
Please fix the pre-commit errors 🙂 |
|
Fixed the pre-commit issues |
|
Hmm, now there's some test failures 🤔 If I understood the tracebacks correctly, should only pass string arguments to |
|
hmm yes, weird! I'm on it. |
|
@jerry-git it can you run the workflow again? I pushed a fix. |
jerry-git
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add messaging about split results
This pull request adds functionality to always report on the split results.
When the splitting is skipped for some reason, a message is printed to the terminal.
When the splitting was successful it reports on how the tests were split.