fix renameTable fail

jerry-024 · Jan 8, 2025 · 685224e · 685224e
1 parent d6039fb
commit 685224e
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/paimon-core/src/main/java/org/apache/paimon/rest/RESTCatalog.java b/paimon-core/src/main/java/org/apache/paimon/rest/RESTCatalog.java
@@ -325,6 +325,10 @@ public void createTable(Identifier identifier, Schema schema, boolean ignoreIfEx
     @Override
     public void renameTable(Identifier fromTable, Identifier toTable, boolean ignoreIfNotExists)
             throws TableNotExistException, TableAlreadyExistException {
+        checkNotBranch(fromTable, "renameTable");
+        checkNotBranch(toTable, "renameTable");
+        checkNotSystemTable(fromTable, "renameTable");
+        checkNotSystemTable(toTable, "renameTable");
         try {
             RenameTableRequest request = new RenameTableRequest(toTable);
             client.post(

diff --git a/paimon-core/src/test/java/org/apache/paimon/rest/MockRESTCatalogServer.java b/paimon-core/src/test/java/org/apache/paimon/rest/MockRESTCatalogServer.java
@@ -29,6 +29,7 @@
 import org.apache.paimon.rest.requests.AlterTableRequest;
 import org.apache.paimon.rest.requests.CreateDatabaseRequest;
 import org.apache.paimon.rest.requests.CreateTableRequest;
+import org.apache.paimon.rest.requests.RenameTableRequest;
 import org.apache.paimon.rest.responses.CreateDatabaseResponse;
 import org.apache.paimon.rest.responses.ErrorResponse;
 import org.apache.paimon.rest.responses.GetDatabaseResponse;
@@ -114,7 +115,27 @@ public MockResponse dispatch(RecordedRequest request) throws InterruptedExceptio
                         String databaseName = resources[0];
                         boolean isTables = resources.length == 2 && "tables".equals(resources[1]);
                         boolean isTable = resources.length == 3 && "tables".equals(resources[1]);
-                        if (isTable) {
+                        if (resources.length == 4 && "rename".equals(resources[3])) {
+                            RenameTableRequest requestBody =
+                                    mapper.readValue(
+                                            request.getBody().readUtf8(), RenameTableRequest.class);
+                            catalog.renameTable(
+                                    Identifier.create(databaseName, resources[2]),
+                                    requestBody.getNewIdentifier(),
+                                    false);
+                            FileStoreTable table =
+                                    (FileStoreTable)
+                                            catalog.getTable(requestBody.getNewIdentifier());
+                            response =
+                                    new GetTableResponse(
+                                            AbstractCatalog.newTableLocation(
+                                                            catalog.warehouse(),
+                                                            requestBody.getNewIdentifier())
+                                                    .toString(),
+                                            table.schema().id(),
+                                            table.schema().toSchema());
+                            return mockResponse(response, 200);
+                        } else if (isTable) {
                             String tableName = resources[2];
                             return tableApiHandler(catalog, request, databaseName, tableName);
                         } else if (isTables) {