Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SafetyAssuredComment to match correct comment #8

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Fix SafetyAssuredComment to match correct comment #8

merged 2 commits into from
Nov 14, 2024

Conversation

garrettblehm
Copy link
Contributor

Resolves #7

garrettblehm and others added 2 commits November 14, 2024 11:09
@garrettblehm
SafetyAssuredComment: Use .last to match the closest comment to the node
413fe78 
Signed-off-by: Garrett Blehm <[email protected]>
@jeromedalbert
Only match comments for the current block node
49fc0ac 
Note: comments can span multiple lines, so check against all lines.
@jeromedalbert jeromedalbert changed the title SafetyAssuredComment: Use .last to match the closest comment to the node Fix SafetyAssuredComment to match correct comment Nov 14, 2024
@jeromedalbert jeromedalbert merged commit 4479211 into jeromedalbert:main Nov 14, 2024
1 check passed
@jeromedalbert
Copy link
Owner

jeromedalbert commented Nov 14, 2024 •
edited
Loading

Thanks! I tweaked the PR so it works for cases where a comment starts with "Safe because ..." but goes on to be a multi-line comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SafetyAssuredComment does not match the correct comment
2 participants
@garrettblehm @jeromedalbert