Merge pull request #3 from vanlooverenkoen/fix/distribution-points

Fixed distribution points implementation

CHANGELOG.md

@@ -1,4 +1,24 @@
 # Changelog
+## 0.2.9
+
+- Fixed distribution points to use tags instead of indexes
+
+## 0.2.8
+
+- Fixed tag 26 that should be a string
+
+## 0.2.7
+
+- version bump
+
+## 0.2.7b
+
+- updated dart
+
+## 0.2.6
+
+- updated ans1lib
+
 ## 0.2.5
 
 - Be more leniant towards unknown OIDs -- treat as Unknown, but do not fail

lib/src/extension.dart

@@ -570,18 +570,30 @@ class DistributionPoint {
   ///     reasons                 [1]     ReasonFlags OPTIONAL,
   ///     cRLIssuer               [2]     GeneralNames OPTIONAL }
   factory DistributionPoint.fromAsn1(ASN1Sequence sequence) {
-    var name = sequence.elements.isEmpty ? null : toDart(sequence.elements[0]);
-    var reasons = sequence.elements.length <= 1
-        ? null
-        : (sequence.elements[1] as ASN1BitString)
-            .valueBytes()
-            .map((v) => DistributionPointReason.values[v])
-            .toList();
-
-    var crlIssuer =
-        sequence.elements.length <= 2 ? null : toDart(sequence.elements[2]);
+    String? name;
+    List<DistributionPointReason>? reasons;
+    String? crlIssuer;
+    for (final element in sequence.elements) {
+      switch (element.tag) {
+        case 0xa0:
+          name = toDart(element);
+          break;
+        case 0xa1:
+          reasons = ((element as ASN1BitString)
+              .valueBytes()
+              .map((v) => DistributionPointReason.values[v])
+              .toList());
+          break;
+        case 0xa2:
+          crlIssuer = String.fromCharCodes(toDart(element));
+          break;
+      }
+    }
     return DistributionPoint(
-        name: name, reasons: reasons, crlIssuer: crlIssuer);
+      name: name,
+      reasons: reasons,
+      crlIssuer: crlIssuer,
+    );
   }
 }
 

pubspec.yaml

@@ -1,6 +1,6 @@
 name: x509b
 description: Dart library for parsing and working with X.509 certificates.
-version: 0.2.8
+version: 0.2.9
 homepage: https://github.com/jeroentrappers/x509
 
 environment: