-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix legacy notification warning #71
Open
xnemesis
wants to merge
4
commits into
jeremywillans:master
Choose a base branch
from
xnemesis:codespace-potential-capybara-v6pxj65xxxfw65v
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix legacy notification warning #71
xnemesis
wants to merge
4
commits into
jeremywillans:master
from
xnemesis:codespace-potential-capybara-v6pxj65xxxfw65v
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xnemesis
commented
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes legacy warning (Issue #69 )
Updated readme to reflect change to generic camera handling in HA. Update README.md Updated to include generic camera instructions for mop roomba devices. Update mop.yaml Updated to remove outdated generic camera config. Update vacuum.yaml Updated to remove outdated generic camera config.
xnemesis
force-pushed
the
codespace-potential-capybara-v6pxj65xxxfw65v
branch
from
September 6, 2024 08:38
6729e91
to
613447c
Compare
Fixes #70 |
nake90
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes it for me
Co-authored-by: Alfonso Arbona Gimeno <[email protected]>
@jeremywillans any reason to not merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.