Add react router #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinkir
approved these changes
Jun 25, 2020
app/webpack/components/ImageGrid.js
Outdated
|
|
||
| useEffect(() => { | ||
| let fetchData = async () => { | ||
| axios.get('/api/v1/images/test_grid_data') |
There was a problem hiding this comment.
Seems like you started to convert to async/await but stopped. I'd recommend either getting rid of the wrapping fetchData function or using await here.
app/webpack/components/ImageGrid.js
Outdated
| .then(response => { | ||
| setImageBoxes(generateImageBoxes(response.data)); | ||
| }) | ||
| .catch(error => console.log(error)); |
There was a problem hiding this comment.
console.error will be easier to see
jeremykirc
force-pushed
the
add-react-router
branch
from
676c10b to
ab06c92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.