Raise error when attempting to render, but rendering was disabled

[janko]

When configuring Rodauth plugin with render: false, it could happen that Rodauth would attempt to render a built-in view/email template:

• attempting to render a built-in email template is possible for JSON or internal requests
• external gem might incorrectly attempt to render a view template in JSON or internal requests
• in Rails apps, people would typically use Action View for rendering view/email templates, and they might miss some when disabling Tilt

Currently, Rodauth raises a rather cryptic:

NoMethodError: undefined method `parse_template_opts' for an instance of #<Class:0x000000011d9e3f40>

I initially started adding the error in rodauth-rails, but I thought it would be beneficial to have this in Rodauth itself. And for this it made sense to me to add a custom error class.

Technically, this doesn't cover the #button case, but those are only rendered within view templates, so the error should already be raised by #_view beforehand.

[jeremyevans]

Thanks for the patch. Can we rename the custom error class from Error to ConfigurationError to make clear this is an error in the user's configuration?

[janko]

Agreed, renamed 👍🏻

I was thinking that afterwards we could reuse this error class in other places:

rodauth/lib/rodauth/features/base.rb

Lines 886 to 889 in 1b4eba5

	def require_response(meth)
	send(meth)
	raise RuntimeError, "#{meth.to_s.sub(/\A_/, '')} overridden without returning a response (should use redirect or request.halt). This is a bug in your Rodauth configuration, not a bug in Rodauth itself."
	end

rodauth/lib/rodauth/features/base.rb

Lines 768 to 771 in 1b4eba5

	def compute_raw_hmac(data)
	raise ArgumentError, "hmac_secret not set" unless hmac_secret
	compute_raw_hmac_with_secret(data, hmac_secret)
	end

rodauth/lib/rodauth/features/jwt.rb

Lines 66 to 69 in 1b4eba5

	def jwt_secret
	raise ArgumentError, "jwt_secret not set"
	end

rodauth/lib/rodauth/features/sms_codes.rb

Lines 516 to 518 in 1b4eba5

	def sms_send(phone, message)
	raise NotImplementedError, "sms_send needs to be defined in the Rodauth configuration for SMS sending to work"
	end

[jeremyevans]

All of those locations are great places to use this error, thank you for doing the research.

[janko]

Updated the mentioned places with the new configuration error ✅