Disable CSRF protection for JSON requests #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, CSRF protection is only disabled for JWT requests, which use token-based instead of cookie-based authentication. However, JSON APIs that require `Content-Type: application/json` and have reasonable CORS restrictions don't appear to be vulnerable to CSRF attacks. Since handling CSRF tokens isn't trivial to do on the client side, we can reduce friction by disabling CSRF protection by default for all JSON requests (including JWT).
|
This looks great, thank you for working on it. I should have time to test and merge this later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, CSRF protection is only disabled for JWT requests, as those use token-based instead of cookie-based authentication. However, JSON APIs that require
Content-Type: application/jsonand have reasonable CORS restrictions don't appear to be vulnerable to CSRF attacks.Since handling CSRF tokens isn't trivial to do on the client side, we can reduce friction by disabling CSRF protection by default for all JSON requests (including JWT).
This is a follow-up to the discussion in #448.