Support custom primary key in accounts table on MySQL #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If one wants to use UUID primary keys on MySQL, one possibility is using
a string column and generating UUIDs in Ruby.
# table definition
create_table :accounts do
String :id, primary_key: true
# ...
end
# rodauth configuration
before_create_account do
account[:id] = SecureRandom.uuid
end
However, Sequel's `#insert` appears to return `0` when the primary key
is something other than an autoincrementing integer on MySQL. This
causes Rodauth's `#save_account` to overwrite the generated UUID with
`0` on the account hash, causing problems down the line in things like
account verification.
We fix this by having `#save_account` only set the `:id` if it hasn't
already been set.
|
Thanks for the patch. This makes sense, and Sequel::Model has same behavior of not overriding an existing primary key value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on janko/rodauth-rails#239, if one wants to use UUID primary keys on MySQL, one possibility is using a string column and generating UUIDs in Ruby.
However, Sequel's
#insertappears to return0when the primary key is something other than an autoincrementing integer on MySQL. This causes Rodauth's#save_accountto overwrite the generated UUID with0on the account hash, causing problems down the line in things like account verification.My idea was to just modify
#save_accountto set the:idif it wasn't already set. My only blocker is how to write tests for this. On Postgres, the primary key value is always returned because of theRETURNINGclause. I was thinking of piggy backing on the$RODAUTH_SPEC_UUIDpath, but that's currently Postgres-only.