Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More static typing #177

Merged
merged 6 commits into from
Dec 19, 2023
Merged

More static typing #177

merged 6 commits into from
Dec 19, 2023

Conversation

speleo3
Copy link
Collaborator

@speleo3 speleo3 commented Dec 13, 2023

  • Parameters typing
  • Options typing
  • vector_algebra tests and refactoring
  • Raise NotImplementedError from unused functions (of which some are broken if you try to run them)

@speleo3 speleo3 requested a review from sobolevnrm December 13, 2023 19:22
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 56 lines in your changes are missing coverage. Please review.

Comparison is base (9d4b59c) 74.05% compared to head (abd3d05) 74.82%.

Files Patch % Lines
propka/hydrogens.py 0.00% 15 Missing ⚠️
propka/output.py 57.14% 15 Missing ⚠️
propka/ligand_pka_values.py 58.33% 5 Missing ⚠️
propka/group.py 75.00% 3 Missing ⚠️
propka/lib.py 93.18% 3 Missing ⚠️
propka/vector_algebra.py 91.66% 3 Missing ⚠️
propka/atom.py 94.73% 2 Missing ⚠️
propka/bonds.py 0.00% 2 Missing ⚠️
propka/parameters.py 97.89% 2 Missing ⚠️
propka/conformation_container.py 93.33% 1 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
+ Coverage   74.05%   74.82%   +0.77%     
==========================================
  Files          25       25              
  Lines        3943     4116     +173     
==========================================
+ Hits         2920     3080     +160     
- Misses       1023     1036      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@speleo3 speleo3 merged commit 5a00d05 into jensengroup:master Dec 19, 2023
8 checks passed
@speleo3 speleo3 deleted the mypy-2 branch December 19, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants