Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jep-227 downstream usage #446

Merged
merged 2 commits into from
Nov 2, 2023
Merged

jep-227 downstream usage #446

merged 2 commits into from
Nov 2, 2023

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Oct 26, 2023 •
edited by jglick
Loading

See JENKINS-XXXXX.

Submitter checklist

  • JIRA issue is well described
  • Appropriate autotests or explanation to why this change has no tests

@Vlatombe Vlatombe mentioned this pull request Oct 26, 2023
Merged
jglick
jglick reviewed Nov 1, 2023
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@jglick jglick marked this pull request as ready for review November 1, 2023 21:25
@jglick jglick requested a review from a team as a code owner November 1, 2023 21:25
@kuisathaverat
Copy link
Contributor

@Vlatombe @jglick Is it ready to merge? Do you want a release of the plugin?

@jglick
Copy link
Member

jglick commented Nov 2, 2023 •
edited
Loading

Is it ready to merge?

Yes, from my PoV anyway.

Do you want a release of the plugin?

It is not necessary since there should be no functional change—just cleaning up technical debt.

@kuisathaverat kuisathaverat merged commit c78cdcb into jenkinsci:main Nov 2, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

@kuisathaverat kuisathaverat kuisathaverat approved these changes

Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vlatombe @kuisathaverat @jglick