Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup POM #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cleanup POM #32

wants to merge 1 commit into from

Conversation

jetersen
Copy link
Member

@jetersen jetersen commented Jul 23, 2018

No description provided.

pvtuan10
pvtuan10 previously approved these changes Jul 31, 2018
Copy link
Member

@pvtuan10 pvtuan10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvtuan10 pvtuan10 dismissed their stale review August 1, 2018 12:38

Need review again

<id>repo.jenkins-ci.org</id>
<url>https://repo.jenkins-ci.org/public/</url>
</pluginRepository>
</pluginRepositories>
Copy link
Member

@pvtuan10 pvtuan10 Aug 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need these tags in plugin/ to do the release in Jenkins update center.

Copy link
Member Author

@jetersen jetersen Aug 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They should already exist in the plugin parent POM

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tbh I think it would be better to move plugin to separate repo so we could support incrementals for both plugin and the agent and kafka-client-lib modules.

Copy link
Member Author

@jetersen jetersen Aug 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or keep the plugin here since that is the name of the repo and then move the other modules to a sparate repo 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be doable, of course. But maybe it is an overkill for now. A follow-up task would be useful

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Casz These tags are needed because the plugin/ component doesn't use parent POM. Hence, it is not possible to release without these tags.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just close the PR then since the version stuff you can do separately

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Casz you can revert these tags and we can integrate the version change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

@oleg-nenashev
Copy link
Member

@Casz Hi. Are you still interested in it?

@jetersen
Copy link
Member Author

You have Allow edits from maintainers. Feel free to fixup the PR 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants