Implement DontKeepBuildForeverAction #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DontKeepBuildForeverAction allows for workflows where an artifact can be 'locked' in one manual promotion for a manual testing procedure. If that procedure fails, the build can be demoted and discarded normally.
|
I understand it follows the design of the original publisher, but actually this design is a bit wrong because it messes up Jenkins terms. My recommendation would be to...
It would be also great to see a test, which actually verifies that the Promotion gets deleted. Maybe it also needs exposing LogRotationStrategy in Promotion configs |
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DontKeepBuildForeverAction allows for workflows where an artifact can be 'locked' in one manual promotion for a longer-term manual testing procedure. If that procedure fails, the build can be demoted and discarded normally.
The unit tests included all pass, but are a bit lame. They duplicate the KeepBuildForeverAction unit tests, but adds the new action as a second promotion action that undoes that work, then asserts that the build is not marked to keep forever.