Review #127
Closed
Review #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-nenashev
requested changes
Jun 3, 2019
| @@ -31,7 +29,10 @@ | |||
| * @deprecated | |||
| */ | |||
| @CheckForNull | |||
| public PromotionBadge isMet(AbstractBuild<?,?> build) { | |||
| public PromotionBadge isMet(Run<?,?> build, RunListener listener) { | |||
| @@ -47,9 +48,12 @@ public PromotionBadge isMet(AbstractBuild<?,?> build) { | |||
| * we know how a build was promoted. | |||
| * Null if otherwise, meaning it shouldn't be promoted. | |||
| */ | |||
| public PromotionBadge isMet(PromotionProcess promotionProcess, AbstractBuild<?,?> build) { | |||
| public PromotionBadge isMet(PromotionProcess promotionProcess, Run<?,?> build) { | |||
|
#128 provides a sample for a binary-compatible migration |
|
Closing it to avoid confusion. We continue work in smaller pull requests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@oleg-nenashev @jonbrohauge @bicschneider
Please look into the code.
The PromotionProcess is not quite fully functioning as i tried to make it an abstract class.
My questions:
I assume that the entire promotion process starts from PromotionCondition abstract class and the flow goes like:
PromotionCondition -> PromotionProcess -> Actual Conditions(Manual,Self...) -> PromotionProcess.....
After listing all the conditions in the DescribableList how do we actually match the input parameter for promotion to the exact class(eg: if user wants manual promotion, how does the plugin send the build/other information to the exact class(self,manual.java.....) for further processing? )
I found the getPromotionCondition method to be close. But this method is not called anywhere in the conditions.?
2)Also if the flow is incorrect please help rectify it. And after the respective promotion modules are called is:
public Future considerPromotion2
used for the final promotion??
Thank You!!