[WIP] [JENKINS-46790] Expose a RecipientProvider for ownership #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ken macro version and use structs
| * | ||
| * @author Victor Martinez | ||
| */ | ||
| @Extension(optional = true) |
There was a problem hiding this comment.
Why do you put it on both class and descriptor?
|
@v1v Hi. Are you still interested in it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-46790
NOTE: This is just a quite basic implementation, copy/paste based with some minor tweaks, without any UTs. Just implemented with the purpose to expose the current implementation and get some early feedback whether it's a good approach and even without any manual yet!
Highlights:
token-macroto be able to use email-extstructdependency to support theSymbolannotation.Questions:
email-extUTs usesPowerMockwhile this plugin uses theJenkinsRuleframework, what's the best approach to add some test coverage?co-ownersrecipient list. What do you think?