-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration for comment-ops
#6985
Conversation
With timja/github-comment-ops#69 commands are being switched to off by default so let's explicitly enable what we want here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+0.5; reviewer makes sense, the rest less so.
label: | ||
enabled: true | ||
removeLabel: | ||
enabled: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use case for these is unclear to me given the large number of maintainers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can have saved replies that do a few things at once,
e.g.
label web-ui,rfe
reviewer jenkinsci/sig-ux
and also this allows non maintainers to setup the labels to save maintainers doing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that do a few things at once
Bot commands only makes sense for people who cannot use the built-in features anyway (unless you like spamming watchers).
this allows non maintainers to setup the labels to save maintainers
Which assumes that people are familiar with how we label things. I already explained in the UX meeting that I've experienced that differently in the subprojects I maintain. Given the large number of active maintainer+ level contributors, the case for this is weak in this repo IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the large number of active maintainer
We don't have what I would call large =/. As one of the (~3) people doing this it would be less work for me if it has been done.
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
With timja/github-comment-ops#69 commands are being switched to off by default so let's explicitly enable what we want here