Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for comment-ops #6985

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Add configuration for comment-ops #6985

merged 1 commit into from
Aug 15, 2022

Conversation

timja
Copy link
Member

@timja timja commented Aug 11, 2022

With timja/github-comment-ops#69 commands are being switched to off by default so let's explicitly enable what we want here

With timja/github-comment-ops#69 commands are being switched to off by default so let's explicitly enable what we want here
@timja timja added the skip-changelog Should not be shown in the changelog label Aug 11, 2022
@timja timja requested a review from a team August 11, 2022 08:09
Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+0.5; reviewer makes sense, the rest less so.

Comment on lines +2 to +5
label:
enabled: true
removeLabel:
enabled: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use case for these is unclear to me given the large number of maintainers.

Copy link
Member Author

@timja timja Aug 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can have saved replies that do a few things at once,

e.g.

label web-ui,rfe

reviewer jenkinsci/sig-ux

and also this allows non maintainers to setup the labels to save maintainers doing it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that do a few things at once

Bot commands only makes sense for people who cannot use the built-in features anyway (unless you like spamming watchers).

this allows non maintainers to setup the labels to save maintainers

Which assumes that people are familiar with how we label things. I already explained in the UX meeting that I've experienced that differently in the subprojects I maintain. Given the large number of active maintainer+ level contributors, the case for this is weak in this repo IMO.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the large number of active maintainer

We don't have what I would call large =/. As one of the (~3) people doing this it would be less work for me if it has been done.

@timja
Copy link
Member Author

timja commented Aug 11, 2022

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Aug 11, 2022
@timja timja merged commit 1afd369 into master Aug 15, 2022
@timja timja deleted the enable-comment-ops branch August 15, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants