Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put correct value for title field in the form #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lakshya8066
Copy link
Contributor

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

This PR fixes the title parameter of credentialId so that it matches the value here.


This now the form has a description of credentialId too, like the rest of the 3 parameters.

@adityasaky
Copy link
Collaborator

I haven't dug into this, is this linked to #40?

@lakshya8066
Copy link
Contributor Author

Yes, but it doesn't solve the issue yet

@ps895r
Copy link

ps895r commented Feb 7, 2023

Thanks for looking into this. Is credentialID something the plugin is supposed to auto-generate or do I need to do some kind of key generation (locally or within Jenkins Pipeline)? @lakshya8066 @adityasaky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants