Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create bridge methods #273

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

basil
Copy link
Member

@basil basil commented Mar 11, 2024

Bridge methods were being defined but not actually created because the bridge method injector was not being executed at build time.

Testing done

Comparing the output of javap -c './target/classes/htmlpublisher/HtmlPublisherTarget$HTMLPublishedForProjectMarkerAction.class' before and after this PR:

--- /tmp/old    2024-03-11 15:04:01.355304753 -0700
+++ /tmp/new    2024-03-11 15:14:33.404180689 -0700
@@ -37,4 +37,14 @@
        0: aload_0
        1: getfield      #7                  // Field actualHtmlPublisherTarget:Lhtmlpublisher/HtmlPublisherTarget;
        4: areturn
+
+  public final hudson.model.AbstractBuild getOwner();
+    Code:
+       0: aload_0
+       1: aload_0
+       2: invokevirtual #67                 // Method getOwner:()Lhudson/model/Run;
+       5: ldc           #17                 // class hudson/model/AbstractBuild
+       7: invokevirtual #69                 // Method getAbstractBuildOwner:(Lhudson/model/Run;Ljava/lang/Class;)Ljava/lang/Object;
+      10: checkcast     #17                 // class hudson/model/AbstractBuild
+      13: areturn
 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant