Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct test failure in non-english system #125

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Correct test failure in non-english system #125

wants to merge 2 commits into from

Conversation

Wadeck
Copy link

@Wadeck Wadeck commented Jul 16, 2018

  • due to the i18n, the expected text was not dynamic. Now it uses the same i18n method to be accurate

@cloudbees/team-foundation

varyvol
varyvol approved these changes Jul 16, 2018
View reviewed changes
Copy link

@varyvol varyvol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One doubt but looks good.

src/test/java/jenkins/plugins/hipchat/ext/tokens/BuildDurationMacroTest.java Outdated
@@ -4,6 +4,8 @@
import static org.assertj.core.api.Assertions.*;
import static org.mockito.BDDMockito.*;

import hudson.Messages;
import hudson.Util;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this import necessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varyvol varyvol varyvol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wadeck @varyvol