Fix xpath for button selection and change test to integration

jenkinsci · Nov 13, 2024 · 3706510 · 3706510
1 parent bf182d4
commit 3706510
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/test/groovy/hudson/plugins/gradle/injection/DevelocityExceptionLogProcessorTest.groovy b/src/test/groovy/hudson/plugins/gradle/injection/DevelocityExceptionLogProcessorTest.groovy
@@ -2,13 +2,13 @@ package hudson.plugins.gradle.injection
 
 import hudson.console.ConsoleNote
 import hudson.model.Actionable
+import hudson.plugins.gradle.BaseJenkinsIntegrationTest
 import hudson.plugins.gradle.BuildScanAction
-import spock.lang.Specification
 import spock.lang.Subject
 
 import java.nio.charset.StandardCharsets
 
-class DevelocityExceptionLogProcessorTest extends Specification {
+class DevelocityExceptionLogProcessorTest extends BaseJenkinsIntegrationTest {
 
     private static final String GRADLE_PLUGIN_ERROR = "Internal error in Gradle Enterprise Gradle plugin: com.acme.FooBar"
     private static final String MAVEN_EXTENSION_ERROR = "[ERROR] Internal error in Gradle Enterprise Maven extension: com.acme.FooBar"

diff --git a/src/test/groovy/hudson/plugins/gradle/injection/InjectionConfigTest.groovy b/src/test/groovy/hudson/plugins/gradle/injection/InjectionConfigTest.groovy
@@ -334,7 +334,8 @@ class InjectionConfigTest extends BaseJenkinsIntegrationTest {
     }
 
     private static HtmlButton getAddButton(HtmlForm form, String label) {
-        def xpath = "//div[text() = '$label']/following-sibling::div[contains(@class, 'setting-main')]//span[contains(@class, 'repeatable-add')]//button[text() = 'Add']"
+        def xpath = "//div[text() = '$label']/following-sibling::div[contains(@class, 'setting-main')]//button[contains(@class, 'repeatable-add')]"
+
         return form.getFirstByXPath(xpath)
     }
 }