Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-50122 Fix rights management for workflow jobs #114

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on May 15, 2019

  1. Fix rights management for workflow jobs

    Workflow jobs does not have the BranchJobProperty set but
    multibranchproject has it. The previous code filtered all workflow jobs
    not having this property making the plugin GitHub Authorization Settings
    not working for those workflow jobs (all simple pipelines).
    jpigree committed May 15, 2019
    Configuration menu
    Copy the full SHA
    07a1bf0 View commit details
    Browse the repository at this point in the history
  2. BranchJobProperty is set only on workflowjobs created by multibranch

    So in order to make multibranch build cancellable we also need to take
    those jobs into account. Those jobs don't have SCMs setup so we need to
    get the scm from the BranchJobProperty like it was done before.
    
    So, now we check if the BranchJobProperty is set and do the adequate
    commands to get the scm.
    
    Also, added tests for CANCEL permission which was never tested.
    jpigree committed May 15, 2019
    Configuration menu
    Copy the full SHA
    a0cce1b View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2019

  1. Do not use wildcard imports

    jpigree committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    2fbc2f3 View commit details
    Browse the repository at this point in the history