Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: can't delete GitHub Enterprise servers #400

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: can't delete GitHub Enterprise servers #400

wants to merge 2 commits into from
+67 −0

Conversation

carlossg
Copy link
Contributor

@carlossg carlossg commented Mar 7, 2021

Description

can't delete GitHub Enterprise servers in Jenkins configuration

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Automated tests have been added to exercise the changes
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verify that the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

Documentation changes

  • Link to jenkins.io PR, or an explanation for why no doc changes are needed

Users/aliases to notify

@bitwiseman
Copy link
Contributor

@carlossg Ping? Do you plan to finish this?

@carlossg
Copy link
Contributor Author

flaky tests on Java 8 ?

@jtnord
Copy link
Member

jtnord commented May 6, 2022

flaky tests on Java 8 ?

nope - deterministic spotbugs issue. https://ci.jenkins.io/job/Plugins/job/github-branch-source-plugin/job/PR-400/39/spotbugs/source.53d2e029-62c1-4810-9467-52517f349249/#62

image

@carlossg carlossg force-pushed the deleteGhEndpoints branch from aa12093 to 5ab5b43 Compare May 7, 2022 10:12
@carlossg
Copy link
Contributor Author

carlossg commented May 7, 2022

that explains a lot

@carlossg carlossg force-pushed the deleteGhEndpoints branch from 5ab5b43 to 0a1eb30 Compare May 7, 2022 10:13
@carlossg
fix: can't delete GitHub Enterprise servers
1798e21 
add a test for GitHubConfiguration
@carlossg carlossg requested a review from a team as a code owner December 27, 2023 17:08
@jtnord jtnord enabled auto-merge March 11, 2024 18:06
@jtnord jtnord added the bug label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlossg @bitwiseman @jtnord