Require Jenkins 2.479 or newer #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to use Jakarta EE 9, StaplerRequest2, and StaplerResponse2
MarkEWaite
added
the
chore
github-actions
bot
added
dependencies
basil
reviewed
Oct 9, 2024
| @@ -115,6 +115,75 @@ public String toString() { | |||
| return s.toString(); | |||
| } | |||
|
|
|||
| /** | |||
| * Copied from scm API plugin. | |||
There was a problem hiding this comment.
This is not maintainable; better to depend on jenkinsci/scm-api-plugin#282 which migrates this method (compatibly!) to EE 9.
Standard is better
MarkEWaite
removed
dependencies
|
Worth a BOM/PCT run I think to ensure that no other plugins are consuming the changed methods. From a visual inspection they looked like one-off forms that are unlikely to be reused, but one never knows. |
MarkEWaite
added a commit
to MarkEWaite/bom
that referenced
this pull request
Oct 9, 2024
* jenkinsci/git-client-plugin#1172 * jenkinsci/git-plugin#1671 * jenkinsci/scm-api-plugin#282 Changes method signatures of several methods in the git plugin from x(StaplerRequest) to x(StaplerRequest2), but hoped that there are no consumers of those API's outside the git plugin.
6 tasks
olamy
approved these changes
Oct 9, 2024
basil
reviewed
Oct 9, 2024
github-actions
bot
added
dependencies
jglick
reviewed
Oct 10, 2024
pom.xml
Outdated
| @@ -114,6 +118,8 @@ | |||
| <dependency> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>scm-api</artifactId> | |||
| <!-- TODO: Replace with release of https://github.com/jenkinsci/scm-api-plugin/pull/282 once it is available --> | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks. Added as 87fcaa7 . Friday's release of plugin BOM will allow that version line to be removed.
MarkEWaite
added
rfe
basil
reviewed
Oct 30, 2024
| <jenkins.version>${jenkins.baseline}.3</jenkins.version> | ||
| <!-- https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ --> | ||
| <jenkins.baseline>2.462</jenkins.baseline> | ||
| <!-- TODO Replace with the standard jenkins.baseline references after LTS requires Java 17 --> |
There was a problem hiding this comment.
Completed in:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require Jenkins 2.479 or newer
Update to use Jakarta EE 9, StaplerRequest2, and StaplerResponse2
Testing done
Automated tests pass. Once the CI job has created an incremental build, I'll inclide it in my test environment for interactive checks.
Submitter checklist