Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CheckoutOption.requiresWorkspaceForPolling override #1526

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Remove CheckoutOption.requiresWorkspaceForPolling override #1526

merged 1 commit into from
Nov 17, 2023

Conversation

jglick
Copy link
Member

@jglick jglick commented Nov 14, 2023 •
edited
Loading

Did not need to override this method as it left the value at the default of false:

git-plugin/src/main/java/hudson/plugins/git/extensions/GitSCMExtension.java

Lines 43 to 45 in daa95b6

public boolean requiresWorkspaceForPolling() {
return false;
}

@jglick jglick requested a review from a team as a code owner November 14, 2023 12:37
MarkEWaite
MarkEWaite approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Nov 14, 2023
@MarkEWaite MarkEWaite enabled auto-merge (squash) November 14, 2023 13:08
@MarkEWaite MarkEWaite merged commit 8293c49 into jenkinsci:master Nov 17, 2023
13 of 14 checks passed
@jglick jglick deleted the CheckoutOption.requiresWorkspaceForPolling branch November 17, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jglick @MarkEWaite