Replace LinkedList with ArrayList

jenkinsci · Jul 31, 2023 · c47bc18 · c47bc18
1 parent 13c23c1
commit c47bc18
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 15 deletions.
diff --git a/src/main/java/jenkins/plugins/git/maintenance/Logs/CacheRecord.java b/src/main/java/jenkins/plugins/git/maintenance/Logs/CacheRecord.java
@@ -20,7 +20,7 @@ public class CacheRecord {
     boolean executionStatus;
     long executionDuration;
 
-    Map<String,LinkedList<CacheRecord>> maintenanceData;
+    Map<String,List<CacheRecord>> maintenanceData;
 
 
     // This is to create a new Cache Record when cache is not present.
@@ -91,20 +91,20 @@ public void setExecutionDuration(long executionDuration) {
 
     public void insertMaintenanceData(CacheRecord record){
         if(record != null && maintenanceData != null) {
-            LinkedList<CacheRecord> list = maintenanceData.get(record.getMaintenanceType());
+            List<CacheRecord> list = maintenanceData.get(record.getMaintenanceType());
             if(list != null) {
-                list.addFirst(record);
+                list.add(0,record);
                 // Maximum storage of 5 Maintenance Records per Cache.
                 if (list.size() > 5)
-                    list.removeLast();
+                    list.remove(list.size()-1);
             }
         }
     }
 
     public List<CacheRecord> getAllMaintenanceRecordsForSingleCache(){
         List<CacheRecord> maintenanceData = new ArrayList<>();
 
-        for(Map.Entry<String,LinkedList<CacheRecord>> entry : this.maintenanceData.entrySet()){
+        for(Map.Entry<String,List<CacheRecord>> entry : this.maintenanceData.entrySet()){
             maintenanceData.addAll(entry.getValue());
         }
 

diff --git a/src/main/java/jenkins/plugins/git/maintenance/Logs/RecordList.java b/src/main/java/jenkins/plugins/git/maintenance/Logs/RecordList.java
@@ -1,22 +1,18 @@
 package jenkins.plugins.git.maintenance.Logs;
 
-import java.util.HashSet;
-import java.util.Iterator;
-import java.util.LinkedList;
-import java.util.List;
-import java.util.Set;
+import java.util.*;
 
 public class RecordList {
-    LinkedList<CacheRecord> maintenanceRecords;
+    List<CacheRecord> maintenanceRecords;
     Set<String> cacheSet;
 
     public RecordList(){
-        maintenanceRecords = new LinkedList<>();
+        maintenanceRecords = new ArrayList<>();
         cacheSet = new HashSet<>();
     }
 
     List<CacheRecord> getMaintenanceRecords(){
-        return new LinkedList<>(maintenanceRecords);
+        return new ArrayList<>(maintenanceRecords);
     }
 
     void addRecord(CacheRecord cacheRecord){
@@ -54,7 +50,7 @@ record = itr.next();
         }
 
         // Creates a new Cache Entry and adds the data.
-        maintenanceRecords.addFirst(cacheRecord);
+        maintenanceRecords.add(0,cacheRecord);
         cacheSet.add(repoName);
     }
 

diff --git a/src/test/java/jenkins/plugins/git/maintenance/Logs/CacheRecordTest.java b/src/test/java/jenkins/plugins/git/maintenance/Logs/CacheRecordTest.java
@@ -82,7 +82,7 @@ public void testInsertMaintenanceData(){
         record.insertMaintenanceData(incrementalRepackRecord);
         record.insertMaintenanceData(looseObjectsRecord);
 
-        for(Map.Entry<String, LinkedList<CacheRecord>> entry : record.maintenanceData.entrySet()){
+        for(Map.Entry<String, List<CacheRecord>> entry : record.maintenanceData.entrySet()){
             assertEquals(1,entry.getValue().size());
         }
     }