breaking: set Java 17 as default #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemeurherve
changed the title
lemeurherve
commented
Oct 11, 2023
dduportal
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
This is really a good change! I'm in favor of adding Archlinux 17.
I'm approving but:
- We want another pair of eyes (e.g. another maintainer reviewing this) given the impact of this change (note that I've triggered a release right before merging this to spread the changes across multiple tags)
- We need confirmation with @MarkEWaite that this change is compliant with his JDK timeline for the Jenkins project
- @lemeurherve do you mind updating the title to materialize that it is breaking? The title being used "as it' by the release-drafter process to generate release notes, it's not obvious for users that it is a breaking change.
lemeurherve
changed the title
|
Title updated 🙂 |
|
Not sure why but a second build started a few minutes ago on a git(hub) event while there haven't been any new commit, and the build status page seems strange:
|
timja
reviewed
Oct 12, 2023
docker-bake.hcl
Outdated
| "${REGISTRY}/${JENKINS_REPO}:archlinux-jdk11", | ||
| "${REGISTRY}/${JENKINS_REPO}:latest-archlinux-jdk11", | ||
| ] | ||
| platforms = ["linux/amd64"] | ||
| } | ||
|
|
||
| target "archlinux_jdk17" { |
There was a problem hiding this comment.
let's not add this, it doesn't make sense for me that we need an arch image
There was a problem hiding this comment.
Removed in 7fc8b83, can be reverted or added in another PR if needed.
lemeurherve
commented
Oct 12, 2023
timja
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets Java 17 as the default JDK and short tags like what has been done in the official Docker image: jenkinsci/docker#1724
Changes:
latest-bookwormtag (to be coherent with the other Linux flavors)Add archlinux-17 images (related: Decide the future of the Archlinux image: either add "Archlinux JDK17" or remove "Archlinux JDK11" #422)removed in 7fc8b83, can be reverted or added in another PR if needed.Testing done
Submitter checklist