Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alpine JDK21] Bump Use Alpine to 3.18.4 #512

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

MarkEWaite
Copy link
Contributor

Use Alpine 3.18.4, not 3.18.3

Passed tests in platformlabeler

jenkinsci/docker#1726 is the matching controller pull request

Testing done

None. Relying on ci.jenkins.io to perform the tests.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Passed tests in platformlabeler

jenkinsci/docker#1726 for the controller
@MarkEWaite MarkEWaite requested a review from a team as a code owner October 1, 2023 12:27
@gounthar
Copy link
Contributor

gounthar commented Oct 1, 2023

Thanks, Mark.
As with docker-ssh-agent, I think updatecli would have updated a few days from now.
The updatecli GitHub Action has run with your PR and given this log:

#######################
# BUMP ALPINE VERSION #
#######################


SOURCES
=======

latestVersion
-------------
WARNING: ⚠ No GitHub Release found, we fallback to published git tags
Searching for version matching pattern "~3"
✔ GitHub release version "v3.18.4" found matching pattern "~3" of kind "semver"


CHANGELOG:
----------
no GitHub Release found for v3.18.4 on "https://github.com/alpinelinux/aports"


CONDITIONS:
===========

testDockerImageExists
---------------------
✔ docker image alpine:3.18.4 found

testDockerfileArg
-----------------
✔ Line "ARG ALPINE_TAG=3.18.4" found, matching the keyword "ARG" and the matcher "ALPINE_TAG".
✔ key map["keyword":"ARG" "matcher":"ALPINE_TAG"] found in Dockerfile "alpine/Dockerfile"


TARGETS
========

updateDockerBake
----------------

**Dry Run enabled**

⚠ - path "variable.ALPINE_FULL_TAG.default" updated from "3.18.3" to "3.18.4" in file "docker-bake.hcl"

updateDockerfile
----------------

**Dry Run enabled**

⚠ The line #23, matched by the keyword "ARG" and the matcher "ALPINE_TAG", is changed from "ARG ALPINE_TAG=3.18.3" to "ARG ALPINE_TAG=3.18.4".
⚠ - changed lines [23] of file "/tmp/updatecli/github/jenkinsci/docker-agent/alpine/Dockerfile"


ACTIONS
========

[Dry Run] An action of kind "github/pullrequest" is expected.

You're still faster than the bot, I can then still have faith that human beings can win against the machine... at least for a while. 🚀

@dduportal
Copy link
Contributor

As expected, #513 bumped the version of Alpine Linux.

However, it did not update the jdk21 Dockerfile: as such I'm pushing a fixup commit here to ensure the updatecli manifest is updated to avoid 2 PRs in the future + I'm renaming the PR title to match its new status

@dduportal dduportal changed the title Use Alpine 3.18.4, not 3.18.3 [Alpine JDK21] Bump Use Alpine to 3.18.4 Oct 2, 2023
@dduportal dduportal merged commit 332bd0d into jenkinsci:master Oct 2, 2023
9 checks passed
@MarkEWaite MarkEWaite deleted the use-alpine-3.18.4 branch October 10, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants