Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dependencies): Tracks JDK21 early access releases. #495

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

gounthar
Copy link
Contributor

@gounthar gounthar commented Sep 8, 2023

As we haven't seen "regular" Temurin JDK21 releases yet, I propose to track the early access versions, in case we receive another one before the official JDK21 release. This should be easy to modify once we move out of the early access mode. This follows PR #492 and issue #587.

I have added an updatecli file to track the JDK21 version, as well as a shell file (borrowed from one of the infra repositories and slightly modified, thanks @smerle33) to help us ensure that the crafted URL is correct.

While not strictly necessary, it's a nice addition in my opinion. If we ever change our minds regarding the way we build the images, transitioning from Temurin's own images to only their JDK binaries, this could prove to be helpful in the future.

Testing done

 updatecli apply --config ./updatecli/updatecli.d/jdk21.yaml --values ./updatecli/values.github-action.yaml --debug


+++++++++++
+ PREPARE +
+++++++++++

Loading Pipeline "./updatecli/updatecli.d/jdk21.yaml"
DEBUG: stage: git-clone

DEBUG: stage: git-clone

DEBUG: cloning git repository: https://github.com/jenkinsci/docker-agent.git in /tmp/updatecli/github/jenkinsci/docker-agent

SCM repository retrieved: 2
DEBUG: cloning git repository: https://github.com/adoptium/temurin21-binaries.git in /tmp/updatecli/github/adoptium/temurin21-binaries
DEBUG:
DEBUG:
DEBUG: fetching remote branches
DEBUG: stage: git-checkout

DEBUG: checkout branch "updatecli_7428af4139f81c23b31d56f1943c6cfe0800a4d2f126ede5a61d677a0adcc7ec", based on "main" to directory "/tmp/updatecli/github/adoptium/temurin21-binaries"
DEBUG: fetching remote branches
DEBUG: stage: git-checkout

DEBUG: checkout branch "updatecli_7428af4139f81c23b31d56f1943c6cfe0800a4d2f126ede5a61d677a0adcc7ec", based on "master" to directory "/tmp/updatecli/github/jenkinsci/docker-agent"
DEBUG:
DEBUG:
DEBUG: No remote name "updatecli_7428af4139f81c23b31d56f1943c6cfe0800a4d2f126ede5a61d677a0adcc7ec"
DEBUG: No remote name "updatecli_7428af4139f81c23b31d56f1943c6cfe0800a4d2f126ede5a61d677a0adcc7ec"


++++++++++++++++++
+ AUTO DISCOVERY +
++++++++++++++++++



++++++++++++
+ PIPELINE +
++++++++++++



#########################################################
# BUMP JDK21 VERSION FOR ALL LINUX IMAGES #
#########################################################


SOURCES
=======

getLatestJDK21EAVersion
-----------------------
DEBUG: stage: git-checkout

DEBUG: checkout branch "updatecli_7428af4139f81c23b31d56f1943c6cfe0800a4d2f126ede5a61d677a0adcc7ec", based on "main" to directory "/tmp/updatecli/github/adoptium/temurin21-binaries"
DEBUG:
DEBUG: No remote name "updatecli_7428af4139f81c23b31d56f1943c6cfe0800a4d2f126ede5a61d677a0adcc7ec"
Searching for version matching pattern ".*-ea-.*"
✔ Git tag "jdk-21+35-ea-beta" found matching pattern ".*-ea-.*" of kind "regex"
DEBUG: empty changelog found for the source


CONDITIONS:
===========

checkIfReleaseIsAvailable
-------------------------
DEBUG: No shell success criteria defined, updatecli fallbacks to historical workflow
DEBUG:  command: /bin/sh /tmp/updatecli/bin/fb063aef0b0daf919e4f1e59666db351f3dc21a3451d2f19630dc86e730839e3.sh
DEBUG: Environment variables
DEBUG:  * UPDATECLI_PIPELINE_STAGE=condition
The shell 🐚 command "/bin/sh /tmp/updatecli/bin/fb063aef0b0daf919e4f1e59666db351f3dc21a3451d2f19630dc86e730839e3.sh" ran successfully with the following output:
----
OK: all JDK URL for version=21+35 are available.
----

✔ shell condition of type "console/output", passing


TARGETS
========

setJDK21Version
---------------
DEBUG: stage: git-checkout

DEBUG: checkout branch "updatecli_7428af4139f81c23b31d56f1943c6cfe0800a4d2f126ede5a61d677a0adcc7ec", based on "master" to directory "/tmp/updatecli/github/jenkinsci/docker-agent"
DEBUG:
DEBUG: No remote name "updatecli_7428af4139f81c23b31d56f1943c6cfe0800a4d2f126ede5a61d677a0adcc7ec"
DEBUG: /tmp/updatecli/github/jenkinsci/docker-agent
DEBUG: Relative path detected: changing from "docker-bake.hcl" to absolute path from SCM: "/tmp/updatecli/github/jenkinsci/docker-agent/docker-bake.hcl"
✔ - path "variable.JAVA21_VERSION.default" already set to "21+35", from file "docker-bake.hcl",
DEBUG: Checking if local changes have been done that should be published
DEBUG: no changes detected between branches "master" and "updatecli_7428af4139f81c23b31d56f1943c6cfe0800a4d2f126ede5a61d677a0adcc7ec"


ACTIONS
========


=============================

REPORTS:



✔ Bump JDK21 version (Jenkins tools) on all controllers:
        Source:
                ✔ [getLatestJDK21EAVersion] Get the latest Adoptium JDK21 version
        Condition:
                ✔ [checkIfReleaseIsAvailable]
        Target:
                ✔ [setJDK21Version] Bump JDK21 version for Linux images in the docker-bake.hcl file


Run Summary
===========
Pipeline(s) run:
  * Changed:    0
  * Failed:     0
  * Skipped:    0
  * Succeeded:  1
  * Total:      1

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@gounthar gounthar requested a review from a team as a code owner September 8, 2023 10:15
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@dduportal dduportal merged commit 4cb61bb into jenkinsci:master Sep 8, 2023
9 checks passed
@gounthar gounthar deleted the updatecli-jdk21 branch September 8, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants