Add a link to Datadog to job details page #447
Conversation
nikita-tkachenko-datadog
added
the
changelog/Added
| public DatadogLinkAction(BuildData buildData) { // ci.pipeline.url%3A"https%3A%2F%2Fgoogle.com" | ||
| String query = String.format("ci_level:pipeline @ci.pipeline.name:\"%s\" @ci.pipeline.number:%s", buildData.getJobName(), buildData.getBuildNumber("")); | ||
| String urlEncodedQuery = URLEncoder.encode(query, StandardCharsets.UTF_8); | ||
| this.url = String.format("https://app.datadoghq.com/ci/pipeline-executions?query=%s", urlEncodedQuery); |
There was a problem hiding this comment.
The host will be different depending on the datacenter and/or, if the org has custom subdomains.
E.g. For orgs in Europe, the url is https://app.datadoghq.eu/........., etc.
This is typically resolved by asking customer to provide a DD_SITE environment variable (this does not cover custom subdomains, tho). For Jenkins, this does not seem the best approach, as it has its own config page.
There was a problem hiding this comment.
I know it's the case when using the intakes, but is it the same when logging in to the UI though? I thought for the app the URL is always the same, as in the static docs we have https://app.datadoghq.com hardcoded.
I might be wrong though, will try asking someone who knows
nikita-tkachenko-datadog
force-pushed
the
nikita-tkachenko/add-datadog-link
branch
from
9bf640e to
490a0c7
Compare
nikita-tkachenko-datadog
changed the base branch from
master
to
nikita-tkachenko/configuration-refactoring-updated
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -218,6 +236,17 @@ | |||
| return FormValidation.ok("Success!"); | |||
| } | |||
|
|
|||
| @RequirePOST | |||
| public ListBoxModel doFillSiteItems() { | |||
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing permission check Warning
nikita-tkachenko-datadog
force-pushed
the
nikita-tkachenko/configuration-refactoring-updated
branch
from
5f3a210 to
d20b98e
Compare
nikita-tkachenko-datadog
force-pushed
the
nikita-tkachenko/configuration-refactoring-updated
branch
from
d20b98e to
b8e26e6
Compare
nikita-tkachenko-datadog
force-pushed
the
nikita-tkachenko/configuration-refactoring-updated
branch
2 times, most recently
from
0404aa5 to
0260867
Compare
nikita-tkachenko-datadog
force-pushed
the
nikita-tkachenko/add-datadog-link
branch
from
490a0c7 to
0277c0d
Compare
Requirements for Contributing to this repository
What does this PR do?
If CI Visibility is enabled, adds a "View in Datadog" link to the details page of every traced job.
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Tested manually.
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.