Implement automatic Test Visibility instrumentation for .NET projects #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-tkachenko-datadog
added
the
changelog/Added
drodriguezhdez
approved these changes
Mar 15, 2024
| String tracerVarOutput = workspacePath.act(new ShellCommandCallable(Collections.emptyMap(), SHOW_TRACER_VARS_TIMEOUT_MILLIS, workspacePath.getRemote() + File.separator + "dd-trace", "ci", "configure", "jenkins")); | ||
|
|
||
| Map<String, String> variables = new HashMap<>(); | ||
| for (String line : tracerVarOutput.split("\n")) { |
There was a problem hiding this comment.
Can tracerVarOutput be null?
There was a problem hiding this comment.
That'd be an exceptional situation, so a NullPointerException would be appropriate (the job itself won't fail anyway, it's just that we'll see the error in the logs)
| continue; | ||
| } | ||
| String[] tokens = line.split("="); | ||
| variables.put(tokens[0], tokens.length == 2 ? tokens[1] : ""); |
There was a problem hiding this comment.
What happens if the variables.get(key) returns empty string. Is this expected from the DotNet configuration perspective?
There was a problem hiding this comment.
Yes, some of the variables can (maybe even should) have an empty value, checked this with an actual .NET project
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/automated-dotnet-instrumentation
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
Implements automatic APM tracer injection and Test Visibility configuration for .NET projects.
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.