-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filtering Events Feature Request #353
Open
dawitgirm
wants to merge
15
commits into
master
Choose a base branch
from
dawit/filter-events
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawitgirm
added
changelog/Added
Added features results into a minor version bump
kind/feature-request
Feature request related issue
labels
Jul 31, 2023
sarah-witt
reviewed
Jul 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🎉
src/main/java/org/datadog/jenkins/plugins/datadog/DatadogUtilities.java
Outdated
Show resolved
Hide resolved
src/main/java/org/datadog/jenkins/plugins/datadog/events/BuildStartedEventImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/org/datadog/jenkins/plugins/datadog/listeners/DatadogComputerListener.java
Outdated
Show resolved
Hide resolved
src/test/java/org/datadog/jenkins/plugins/datadog/DatadogGlobalConfigurationTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/datadog/jenkins/plugins/datadog/DatadogGlobalConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/org/datadog/jenkins/plugins/datadog/DatadogGlobalConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/org/datadog/jenkins/plugins/datadog/DatadogGlobalConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/org/datadog/jenkins/plugins/datadog/DatadogGlobalConfiguration.java
Outdated
Show resolved
Hide resolved
src/test/java/org/datadog/jenkins/plugins/datadog/listeners/DatadogFilteringEventsTest.java
Show resolved
Hide resolved
src/main/java/org/datadog/jenkins/plugins/datadog/events/ConfigChangedEventImpl.java
Show resolved
Hide resolved
…ties.java Co-authored-by: Sarah Witt <[email protected]>
…lConfiguration.java Co-authored-by: Sarah Witt <[email protected]>
…lConfigurationTest.java Co-authored-by: Sarah Witt <[email protected]>
…lConfiguration.java Co-authored-by: Sarah Witt <[email protected]>
…e string rather than event
… for env variable conflicts
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog/Added
Added features results into a minor version bump
documentation
Documentation related changes
kind/feature-request
Feature request related issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
Currently, the filtering of events was limited to a toggle which turned on/off categories of events with no granular control of specific events to be sent.
Link to Issue
Description of the Change
Filtering is done by adding names for all the events and having users manually write include/exclude lists of specific events that they do/don't want. The higher level control of the toggles are still available but more specific include/excludes can be done with these lists. The config changed event was also removed completely as this event was blocked by the events team.
Alternate Designs & Possible Drawbacks
Link to RFC discussing this
Verification Process
Link to testing plan for unit and manual testing
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/
label attached. If applicable it should have thebackward-incompatible
label attached.do-not-merge/
label attached.kind/
andseverity/
labels attached at least.