Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering Events Feature Request #353

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

dawitgirm
Copy link
Contributor

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Currently, the filtering of events was limited to a toggle which turned on/off categories of events with no granular control of specific events to be sent.

Link to Issue

Description of the Change

Filtering is done by adding names for all the events and having users manually write include/exclude lists of specific events that they do/don't want. The higher level control of the toggles are still available but more specific include/excludes can be done with these lists. The config changed event was also removed completely as this event was blocked by the events team.

Alternate Designs & Possible Drawbacks

Link to RFC discussing this

Verification Process

Link to testing plan for unit and manual testing

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@dawitgirm dawitgirm added changelog/Added Added features results into a minor version bump kind/feature-request Feature request related issue labels Jul 31, 2023
Copy link
Collaborator

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

@github-actions github-actions bot added the documentation Documentation related changes label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Added Added features results into a minor version bump documentation Documentation related changes kind/feature-request Feature request related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants