Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed posix-api dependency from pom #349

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dawitgirm
Copy link
Contributor

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Issue: The jnr-posix-api dependency was added to the jenkins BOM, so this PR removes the redundant dependency linkage in the pom.xml.

Description of the Change

The dependency in the pom.xml was removed.

Alternate Designs

Possible Drawbacks

Verification Process

Passed all local tests and tested manually with a local Jenkins instance using both the agent and HTTP forwarding methods to connect jenkins with Datadog.

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@dawitgirm dawitgirm added changelog/no-changelog Changes don't appear in changelog dev/tooling Tooling related changes labels Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog Changes don't appear in changelog dev/tooling Tooling related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant