Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility error in CredentialsProvider #492

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Compatibility error in CredentialsProvider #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/java/com/cloudbees/plugins/credentials/CredentialsProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1190,7 +1190,10 @@ public <C extends Credentials> List<C> getCredentialsInItemGroup(@NonNull Class<
if (Util.isOverridden(CredentialsProvider.class, getClass(), "getCredentials", Class.class, ItemGroup.class, org.acegisecurity.Authentication.class, List.class)) {
return getCredentials(type, itemGroup, authentication == null ? null : org.acegisecurity.Authentication.fromSpring(authentication), domainRequirements);
}
throw new AbstractMethodError("Implement getCredentialsInItemGroup");
if (Util.isOverridden(CredentialsProvider.class, getClass(), "getCredentials", Class.class, ItemGroup.class, org.acegisecurity.Authentication.class)) {
return getCredentials(type, itemGroup, authentication == null ? null : org.acegisecurity.Authentication.fromSpring(authentication));
}
throw new AbstractMethodError("Implement getCredentialsInItemGroup from " + getClass());
}

/**
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/cloudbees/plugins/credentials/CredentialsStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ public boolean hasPermission2(@NonNull Authentication a, @NonNull Permission per
Permission.class)) {
return hasPermission(org.acegisecurity.Authentication.fromSpring(a), permission);
}
throw new AbstractMethodError("Implement hasPermission2");
throw new AbstractMethodError("Implement hasPermission2 from " + getClass());
}

/**
Expand Down
Loading