Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exception handling if metric is missing #132

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Nov 3, 2024

If the metric is omitted then the correct message should be shown.

@uhafner uhafner added the enhancement Enhancement of existing functionality label Nov 3, 2024
Copy link

github-actions bot commented Nov 3, 2024

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 294 passed)
   〰️   Line Coverage: 96% (84 missed lines)
   ➰   Branch Coverage: 92% (77 missed branches)
   PIT   Mutation Coverage: 90% (113 survived mutations)
   🔬   Test Strength: 93% (78 survived mutations in tested code)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: No warnings
   SpotBugs   SpotBugs: No bugs
   🐛   Error Prone: No bugs
   OWASP Dependency Check   OWASP Dependency Check: No vulnerabilities
   🌀   Cyclomatic Complexity: 655
   💡   Cognitive Complexity: 535
   📝   Non Commenting Source Statements: 2979
   ➿   N-Path Complexity: 1489


Created by Quality Monitor v1.12.0 (#910ef11). More details are shown in the GitHub Checks Result.

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@4406f87). Learn more about missing BASE report.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage        ?   93.28%           
  Complexity      ?      842           
=======================================
  Files           ?       28           
  Lines           ?     2308           
  Branches        ?      340           
=======================================
  Hits            ?     2153           
  Misses          ?       84           
  Partials        ?       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uhafner uhafner merged commit 4f5a182 into main Nov 3, 2024
35 checks passed
@uhafner uhafner deleted the undefined-metric branch November 3, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant