Provide JUnit5 compatible alternative for RoundTripAbstractTest and RestartableJenkinsRule #2623
+251
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strangelookingnerd
force-pushed
the
alternative_for_restartable_jenkins_rule
branch
from
35a739c to
942e4d0
Compare
There was a problem hiding this comment.
This is a good example of how one can migrate from using RestartableJenkinsRule to JenkinsRule.restart()
There was a problem hiding this comment.
This is an example of how one can migrate from using RoundTripAbstractTest to AbstractRoundTripTest
| @@ -44,7 +44,9 @@ | |||
| * text configured. | |||
| * | |||
| * @since 1.20 | |||
| * @deprecated Consider migrating to JUnit5 and use {@link io.jenkins.plugins.casc.misc.junit.jupiter.AbstractRoundTripTest} instead. | |||
There was a problem hiding this comment.
This is optional, but I'd like to make users aware of the alternative.
| * logger) that guarantees the config is loaded. Usually a weird text configured. | ||
| */ | ||
| @WithJenkins | ||
| public abstract class AbstractRoundTripTest { |
There was a problem hiding this comment.
I used a slightly different name besides a different package to reduce the risk of mix-ups. Not sure if this is the best way, so feedback is welcome.
...-harness/src/main/java/io/jenkins/plugins/casc/misc/junit/jupiter/AbstractRoundTripTest.java
Outdated
Show resolved
Hide resolved
timja
reviewed
Jan 16, 2025
...-harness/src/main/java/io/jenkins/plugins/casc/misc/junit/jupiter/AbstractRoundTripTest.java
Show resolved
Hide resolved
timja
reviewed
Jan 16, 2025
...-harness/src/main/java/io/jenkins/plugins/casc/misc/junit/jupiter/AbstractRoundTripTest.java
Show resolved
Hide resolved
timja
reviewed
Jan 16, 2025
...-harness/src/main/java/io/jenkins/plugins/casc/misc/junit/jupiter/AbstractRoundTripTest.java
Outdated
Show resolved
Hide resolved
strangelookingnerd
force-pushed
the
alternative_for_restartable_jenkins_rule
branch
2 times, most recently
from
22b3768 to
8dc5328
Compare
…estartableJenkinsRule
strangelookingnerd
force-pushed
the
alternative_for_restartable_jenkins_rule
branch
from
8dc5328 to
5319f9a
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that jenkinsci/jenkins-test-harness#716 is available, it is possible to replace usage of
RestartableJenkinsRulein most scenarios.This change paves the way to provide a JUnit5-compatible implementation of
RoundTripAbstractTestthat does not rely onRestartableJenkinsRuleanymore.This PR is still a little rough on the edges and therefore created as draft - however feedback is highly appreciated.
Your checklist for this pull request