Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jenkins Security Scan action #138

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Update Jenkins Security Scan action #138

merged 1 commit into from
Aug 12, 2024

Conversation

strangelookingnerd
Copy link
Contributor

In order to unify the actions configuration this PR will

  • Removes the hard-coded java-version in order to rely on the default
  • Adds a java-cache configuration to speed-up the actions buld time
  • Adds permissions allowing the action to create security issues
  • Removes non-existant target branches

Please note this PR was created semi-automatically. If you find any issue with it, don't hesitate to ping me.
See discussion in jenkinsci/asm-api-plugin#36

Testing done

Awaiting run of the action to verify the changes...

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link
Member

@damianszczepanik damianszczepanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the goal of this change?

@strangelookingnerd
Copy link
Contributor Author

In this particular instance it’s about not hard-coding the Java version that is used during the build. The template this action relies on defines its own default which is sufficient most of the time.
You could compare it to overriding the java.version property in your pom.xml: The property is already defined in the parent pom file / plugin bom. A plugin rarely has the need to change this value on its own but will get the change automatically in case Jenkins will require a newer version of Java - like it will be the case soon.
In most cases this approach will reduce the cost of maintenance in the long run.

@damianszczepanik damianszczepanik merged commit c242a66 into jenkinsci:master Aug 12, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants