Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert credentials:1305.v04f5ec1f3743 #2618

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Oct 27, 2023

Revert the credentials 1305.x plugin inclusion in bom

1305.x changelog notes that a regression is being investigated as reported in jenkinsci/credentials-plugin#490 (comment)

A pull request has been submitted to resolve the issue in a new release:

Testing done

No testing done. Rely on interactive testing of upcoming releases of the credentials plugin.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes

@MarkEWaite MarkEWaite requested a review from a team as a code owner October 27, 2023 15:16
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"If it's broken, rip it out" - Jeff Bonwick

@jglick
Copy link
Member

jglick commented Oct 27, 2023

Does not really matter for purposes of bom, but sure.

@MarkEWaite MarkEWaite merged commit 24c9217 into jenkinsci:master Oct 27, 2023
4 checks passed
@MarkEWaite MarkEWaite deleted the revert-credentials-1305.x branch October 27, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants