Implement Describable from Script, not AbstractScript
#406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
commented
Jan 13, 2025
|
|
||
| /* | ||
| * Serial UID. | ||
| */ | ||
| private static final long serialVersionUID = 4027103576278802323L; | ||
|
|
||
| // TODO could be pulled up into Script (default method); | ||
| // in fact this intermediate type could probably be deleted | ||
| // (assuming there is no Java serialization outside of Remoting, |
There was a problem hiding this comment.
(Serial form compatibility for types used in Remoting is irrelevant, since the agent always runs the same bytecode as the controller.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this is used as the declared type of a nested field in higher
Describables,active-choices-plugin/src/main/java/org/biouno/unochoice/CascadeChoiceParameter.java
Lines 125 to 126 in 59bda84
Describable.