Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cd.yaml template: Enhance with validate_only config option #140

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

mhoffrog
Copy link
Contributor

@mhoffrog mhoffrog commented Sep 20, 2024

@jglick @timja

Description

This PR is following up PR jenkins-infra/github-reusable-workflows #32

The cd.yaml template is enhanced as follows:

  • Add input selection for the manual trigger to provide the validate_only option of jenkins-infra/github-reusable-workflows/.github/workflows/maven-cd.yml
  • Add appropriate inline help comments for individual use case config options

Testing done

see action runs with unleash-plugin cd.yaml:

  1. automtically triggered: https://github.com/jenkinsci/unleash-plugin/actions/runs/10956424587
  2. manually triggered: https://github.com/jenkinsci/unleash-plugin/actions/runs/10956762080
  3. Screenshot of manual trigger start - updated after description format improvement commit:
    cd_manual_input_for_validate_only

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

- Add inline help comments for individual use case config options
workflow-templates/cd.yaml Outdated Show resolved Hide resolved
@timja timja added the enhancement New feature or request label Sep 20, 2024
@timja timja merged commit 98fe9a4 into jenkinsci:master Sep 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants