Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seperate jx installation from cluster creation #226

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rochana-atapattu
Copy link

@rochana-atapattu rochana-atapattu commented Sep 28, 2022

We can use custom or predefined cluster for jx installation #225 . Here I have extracted the JX related code from GKE related code so that we have the option to install JX to exsisting cluster.

@jenkins-x-bot
Copy link
Contributor

Hi @rochana-atapattu. Thanks for your PR.

I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign msvticket
You can assign the PR to them by writing /assign @msvticket in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roulettedares
Copy link
Contributor

This seems like a good idea. I believe that this should be a nondestructive/safe change for downstream users of the module since the google_container_cluster object itself remains in the same path at module.cluster. @rochana-atapattu have you tried to apply the new module logic to an existing cluster?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants