Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag the Gatling plugin with adopt-this-plugin #804

Closed
wants to merge 1 commit into from

Conversation

slandelle
Copy link

Hello,

We of Gatling no longer maintain this plugin (we have a distinct one for Gatling Enterprise) and would like to mark it for adoption.

Thanks!

@zbynek
Copy link
Contributor

zbynek commented Sep 28, 2024

To set a label for a plugin you can just add a topic to the GitHub repository -- it's preferred over using the label file here.
#762 (comment)

@slandelle
Copy link
Author

slandelle commented Sep 28, 2024

@zbynek I did both as instructed in the official documentation: https://www.jenkins.io/doc/developer/plugin-governance/adopt-a-plugin/#how-can-i-mark-a-plugin-for-adoption:

Add the adopt-this-plugin label to the plugin. It can be done in 2 ways:

  • Put an adopt-this-plugin topic in the plugin’s GitHub repository. If you have multiple plugins inside a single repository, it will apply to all of them
  • Add an adopt-this-plugin label to the plugin entry in the Update Center’s label-definitions.properties file

@zbynek
Copy link
Contributor

zbynek commented Sep 28, 2024

The documentation mentions two ways to do the same thing, there's no benefit in doing both.

The plugin is displayed as "up for adoption" on the plugin site (https://plugins.jenkins.io/gatling/) so I think this PR can be closed.

@slandelle
Copy link
Author

@zbynek My point was that you might want to update your documentation if the second way is not recommended and the first one suffices. Anyway, closing as instructed.

@slandelle slandelle closed this Sep 28, 2024
MarkEWaite added a commit to MarkEWaite/jenkins.io that referenced this pull request Sep 28, 2024
jenkins-infra/update-center2#804 (comment)
notes that two ways are offered but only one of the two ways is needed.
Since one of the two ways is preferred due to its scalability, let's
state that in the documentation.
gounthar pushed a commit to jenkins-infra/jenkins.io that referenced this pull request Sep 28, 2024
jenkins-infra/update-center2#804 (comment)
notes that two ways are offered but only one of the two ways is needed.
Since one of the two ways is preferred due to its scalability, let's
state that in the documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants