Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to bouncycastle jdk18on with version 1.78.1 #785

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on May 29, 2024

  1. Update to bouncycastle jdk18on with version 1.78.1

    The Jenkins update-center2 was still using a bouncycastle version from
    September 2008. Even though I exactly followed the instructions from the
    update-center2's README.adoc file, I was not able to generate an OpenSSL
    key (and certificate) that would work with that bouncycastle version.
    Debugging into the library revealed that the old bouncycastle version
    doesn't support reading private keys starting with the line
    `-----BEGIN PRIVATE KEY-----`.
    
    Instead, bouncycastle only supported one of the following starting lines
    for private keys:
    
    - `-----BEGIN RSA PRIVATE KEY-----`
    - `-----BEGIN DSA PRIVATE KEY-----`
    - `-----BEGIN EC PRIVATE KEY-----`
    
    In the case of a starting line of `BEGIN PRIVATE KEY`, the
    `readObject()` method of the `PEMReader` would just return `null` and
    cause the update-center2 to crash.
    
    However, the documented command `openssl genrsa -out demo.key 4096` also
    generates a key file starting with `BEGIN PRIVATE KEY` when using modern
    versions of OpenSSL (version 3.0.13 in my case).
    
    For this reason, this change updates the used bouncycastle library to
    the most recent version, with which I was able to sign the files again.
    pathob committed May 29, 2024
    Configuration menu
    Copy the full SHA
    7061702 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Configuration menu
    Copy the full SHA
    607427e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4136f2d View commit details
    Browse the repository at this point in the history