Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(vpc) private subnets: disable IPv6 and experiment around naming #57

Merged
merged 1 commit into from
Dec 5, 2024
Merged

hotfix(vpc) private subnets: disable IPv6 and experiment around naming #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions vpc.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,12 @@ module "vpc" {
cidr = local.vpc_cidr

# dual stack https://github.com/terraform-aws-modules/terraform-aws-vpc/blob/v5.13.0/examples/ipv6-dualstack/main.tf
enable_ipv6 = true
public_subnet_assign_ipv6_address_on_creation = true
enable_ipv6 = true
public_subnet_assign_ipv6_address_on_creation = true
private_subnet_assign_ipv6_address_on_creation = false
private_subnet_ipv6_native = false
private_subnet_enable_dns64 = false
private_subnet_enable_resource_name_dns_aaaa_record_on_launch = false

manage_default_network_acl = false
map_public_ip_on_launch = true
Expand All @@ -21,17 +25,24 @@ module "vpc" {
azs = [for subnet_name, subnet_data in local.vpc_private_subnets : subnet_data.az]

# only private subnets for security (to control allowed outbound connections)
private_subnets = [for subnet in local.vpc_private_subnets : subnet.cidr]
public_subnets = [for subnet in local.vpc_public_subnets : subnet.cidr]
private_subnets = [for subnet in local.vpc_private_subnets : subnet.cidr]
public_subnets = [for subnet in local.vpc_public_subnets : subnet.cidr]
private_subnet_names = [for subnet in local.vpc_private_subnets : subnet.name]
private_subnet_tags = local.common_tags

public_subnet_ipv6_prefixes = range(length(local.vpc_public_subnets))
private_subnet_ipv6_prefixes = range(10, length(local.vpc_private_subnets) + 10)

# public_subnet_names = [for subnet in local.vpc_public_subnets : subnet.name]
# public_subnet_tags = local.common_tags

public_subnet_ipv6_prefixes = range(length(local.vpc_public_subnets))

# private_subnet_ipv6_prefixes = range(10, length(local.vpc_private_subnets) + 10)

# One NAT gateway per subnet (default)
# ref. https://registry.terraform.io/modules/terraform-aws-modules/vpc/aws/latest#one-nat-gateway-per-subnet-default
enable_nat_gateway = true
single_nat_gateway = false
one_nat_gateway_per_az = false
enable_nat_gateway = true
single_nat_gateway = false
# one_nat_gateway_per_az = true

enable_dns_hostnames = true
}