fix(vpc) order subnets with array to avoid unexpected destroy/recreate when only adding subnets #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e when only adding subnets Signed-off-by: Damien Duportal <[email protected]>
|
|
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to jenkins-infra/helpdesk#4319
Fixup of #36 to avoid #32 deployment failure
#36 did introduce a new data structure to declare subnets with automatic CIDR calculation.
Alas I used a
foriteration to pass the data from thelocalsto thevpcmodule, which used lexicographic order.So adding a new subnets in the data structure had the effect to expect a destroy-recreate (as it inserted
eks2between the 2 existing subnets instead of after).This PR switches the data structure to an array which order is kept by the iteration.