Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(updatecli): add a manifest for golang #982

Merged
merged 5 commits into from
Jan 23, 2024
Merged

chore(updatecli): add a manifest for golang #982

merged 5 commits into from
Jan 23, 2024

Conversation

smerle33
Copy link
Contributor

@smerle33 smerle33 commented Jan 11, 2024 •
edited
Loading

as per #198

after #981

@smerle33 smerle33 mentioned this pull request Jan 11, 2024
Open
36 tasks
@smerle33 smerle33 requested a review from dduportal January 11, 2024 13:40
@smerle33 smerle33 mentioned this pull request Jan 11, 2024
Closed
dduportal
dduportal requested changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Almost there: there is an error in the manfiest (see comment)

updatecli/updatecli.d/golang.yml Outdated Show resolved Hide resolved
@smerle33 smerle33 requested a review from dduportal January 23, 2024 10:26
@dduportal dduportal merged commit f82cb62 into jenkins-infra:main Jan 23, 2024
1 check was pending
@smerle33 smerle33 deleted the updatecli/golang branch May 20, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal approved these changes

Assignees
No one assigned
Labels
chore golang
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smerle33 @dduportal