-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tfsec (v1.28.1) on all platforms #459
Conversation
Thanks for this new PR @Kevin-CB 👏 FYI there are two issues:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found the culprit for the first issue.
As far as I can tell (ref. https://github.com/jenkins-infra/packer-images/pull/459/files#diff-40afc0140eabc567a7fffe74f8e456d714ec88e36e9aca911d2e95cd8696a40bR2), the powershell script fails when its instructions fails. Just tested it and it works as expected. I wonder if the mechanism we use for the sanity check is not the culprit: my powershell-fu is not really good but from https://ss64.com/ps/call.html it looks to me that the exit code is not captured. #337 is the same (I'm adding more note on the issue to avoid polluting the discussion here) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, thanks a lot! 👏
For #198
This PR add tfsec on all platforms